On 6/10/21 1:43 AM, Chandan Babu R wrote:
On 08 Jun 2021 at 22:49, Darrick J. Wong wrote:
From: Darrick J. Wong <djwong@xxxxxxxxxx>
In the tests/*/group files, group names are found in the Nth columns of
the file, where N > 1. The grep expression to warn about unknown groups
is not correct (since it currently checks column 1), so fix this.
Looks good to me.
Reviewed-by: Chandan Babu R <chandanrlinux@xxxxxxxxx>
Signed-off-by: Darrick J. Wong <djwong@xxxxxxxxxx>
Looks ok
Reviewed-by: Allison Henderson <allison.henderson@xxxxxxxxxx>
---
new | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/new b/new
index bb427f0d..357983d9 100755
--- a/new
+++ b/new
@@ -243,10 +243,7 @@ else
#
for g in $*
do
- if grep "^$g[ ]" $tdir/group >/dev/null
- then
- :
- else
+ if ! grep -q "[[:space:]]$g" "$tdir/group"; then
echo "Warning: group \"$g\" not defined in $tdir/group"
fi
done
