On Mon, Jun 07, 2021 at 03:24:59PM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong <djwong@xxxxxxxxxx> > > Hoist the code in xfs_iget_cache_hit that restores the VFS inode state > to an xfs_inode that was previously vfs-destroyed. The next patch will > add a new set of state flags, so we need the helper to avoid > duplication. > > Signed-off-by: Darrick J. Wong <djwong@xxxxxxxxxx> > --- > fs/xfs/xfs_icache.c | 139 ++++++++++++++++++++++++++++++--------------------- > 1 file changed, 81 insertions(+), 58 deletions(-) > > > diff --git a/fs/xfs/xfs_icache.c b/fs/xfs/xfs_icache.c > index 4e4682879bbd..4d4aa61fbd34 100644 > --- a/fs/xfs/xfs_icache.c > +++ b/fs/xfs/xfs_icache.c > @@ -350,19 +350,19 @@ xfs_inew_wait( > * need to retain across reinitialisation, and rewrite them into the VFS inode > * after reinitialisation even if it fails. > */ > -static int > +static inline int > xfs_reinit_inode( > struct xfs_mount *mp, > struct inode *inode) Don't use inline here as it's a pretty big function - it's a static function so let the compiler decide if inlining is worth it. Otherwise looks ok. Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx> -- Dave Chinner david@xxxxxxxxxxxxx
