Hi,
On Sat, Jun 05, 2021 at 04:52:50PM +0800, Shaokun Zhang wrote:
> 'error' will be initialized, so clean up the redundant initialization.
>
> Cc: "Darrick J. Wong" <djwong@xxxxxxxxxx>
> Signed-off-by: Shaokun Zhang <zhangshaokun@xxxxxxxxxxxxx>
This makes no difference in the resulting code.
Particularly, I'd rather have such variables explicitly initialized. This
function is small, so it's easy to see its initialization later in the code, but
still, IMHO, it's way better to see the 'default error values' explicit at the
beginning of the function. But, it's just my 'visual' preference :)
> ---
> fs/xfs/xfs_buf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_buf.c b/fs/xfs/xfs_buf.c
> index 592800c8852f..59991c8c7127 100644
> --- a/fs/xfs/xfs_buf.c
> +++ b/fs/xfs/xfs_buf.c
> @@ -707,7 +707,7 @@ xfs_buf_get_map(
> {
> struct xfs_buf *bp;
> struct xfs_buf *new_bp;
> - int error = 0;
> + int error;
>
> *bpp = NULL;
> error = xfs_buf_find(target, map, nmaps, flags, NULL, &bp);
> --
> 2.7.4
>
--
Carlos
