Hi Dave, Thank you for the patch! Yet something to improve: [auto build test ERROR on xfs-linux/for-next] [also build test ERROR on linus/master v5.13-rc4 next-20210602] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Dave-Chinner/xfs-CIL-and-log-optimisations/20210603-134113 base: https://git.kernel.org/pub/scm/fs/xfs/xfs-linux.git for-next config: arc-randconfig-r034-20210603 (attached as .config) compiler: arc-elf-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/7832a61eefffdb48fdd863bbb0da4b8b7a4e2bb9 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Dave-Chinner/xfs-CIL-and-log-optimisations/20210603-134113 git checkout 7832a61eefffdb48fdd863bbb0da4b8b7a4e2bb9 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arc If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@xxxxxxxxx> All errors (new ones prefixed by >>): In file included from include/linux/string.h:6, from include/linux/uuid.h:12, from fs/xfs/xfs_linux.h:10, from fs/xfs/xfs.h:22, from fs/xfs/xfs_log_cil.c:6: fs/xfs/xfs_log_cil.c: In function 'xlog_cil_pcp_alloc': >> fs/xfs/xfs_log_cil.c:1454:6: error: void value not ignored as it ought to be 1454 | if (xlog_cil_pcp_hpadd(cil) < 0) { | ^~~~~~~~~~~~~~~~~~~~~~~ include/linux/compiler.h:58:52: note: in definition of macro '__trace_if_var' 58 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond)) | ^~~~ fs/xfs/xfs_log_cil.c:1454:2: note: in expansion of macro 'if' 1454 | if (xlog_cil_pcp_hpadd(cil) < 0) { | ^~ >> fs/xfs/xfs_log_cil.c:1454:6: error: void value not ignored as it ought to be 1454 | if (xlog_cil_pcp_hpadd(cil) < 0) { | ^~~~~~~~~~~~~~~~~~~~~~~ include/linux/compiler.h:58:61: note: in definition of macro '__trace_if_var' 58 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond)) | ^~~~ fs/xfs/xfs_log_cil.c:1454:2: note: in expansion of macro 'if' 1454 | if (xlog_cil_pcp_hpadd(cil) < 0) { | ^~ >> fs/xfs/xfs_log_cil.c:1454:6: error: void value not ignored as it ought to be 1454 | if (xlog_cil_pcp_hpadd(cil) < 0) { | ^~~~~~~~~~~~~~~~~~~~~~~ include/linux/compiler.h:69:3: note: in definition of macro '__trace_if_value' 69 | (cond) ? \ | ^~~~ include/linux/compiler.h:56:28: note: in expansion of macro '__trace_if_var' 56 | #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) ) | ^~~~~~~~~~~~~~ fs/xfs/xfs_log_cil.c:1454:2: note: in expansion of macro 'if' 1454 | if (xlog_cil_pcp_hpadd(cil) < 0) { | ^~ vim +1454 fs/xfs/xfs_log_cil.c 1443 1444 static void __percpu * 1445 xlog_cil_pcp_alloc( 1446 struct xfs_cil *cil) 1447 { 1448 void __percpu *pcp; 1449 1450 pcp = alloc_percpu(struct xlog_cil_pcp); 1451 if (!pcp) 1452 return NULL; 1453 > 1454 if (xlog_cil_pcp_hpadd(cil) < 0) { 1455 free_percpu(pcp); 1456 return NULL; 1457 } 1458 return pcp; 1459 } 1460 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
Attachment:
.config.gz
Description: application/gzip
