On Wed, Jun 02, 2021 at 08:12:59PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@xxxxxxxxxx>
>
> In preparation for renaming struct xfs_eofblocks to struct xfs_icwalk,
> change the prefix of the existing XFS_EOF_FLAGS_* flags to
> XFS_ICWALK_FLAG_ and convert all the existing users. This adds a degree
> of interface separation between the ioctl definitions and the incore
> parameters.
>
> Signed-off-by: Darrick J. Wong <djwong@xxxxxxxxxx>
> ---
> fs/xfs/xfs_file.c | 4 ++--
> fs/xfs/xfs_icache.c | 40 ++++++++++++++++++++--------------------
> fs/xfs/xfs_icache.h | 19 +++++++++++++++++--
> 3 files changed, 39 insertions(+), 24 deletions(-)
.....
> diff --git a/fs/xfs/xfs_icache.h b/fs/xfs/xfs_icache.h
> index 191620a069af..2f4a27a3109c 100644
> --- a/fs/xfs/xfs_icache.h
> +++ b/fs/xfs/xfs_icache.h
> @@ -18,6 +18,21 @@ struct xfs_eofblocks {
> int icw_scan_limit;
> };
>
> +/* Flags that we borrowed from struct xfs_fs_eofblocks */
"Flags that reflect xfs_fs_eofblocks functionality"
> +#define XFS_ICWALK_FLAG_SYNC (XFS_EOF_FLAGS_SYNC)
> +#define XFS_ICWALK_FLAG_UID (XFS_EOF_FLAGS_UID)
> +#define XFS_ICWALK_FLAG_GID (XFS_EOF_FLAGS_GID)
> +#define XFS_ICWALK_FLAG_PRID (XFS_EOF_FLAGS_PRID)
> +#define XFS_ICWALK_FLAG_MINFILESIZE (XFS_EOF_FLAGS_MINFILESIZE)
> +#define XFS_ICWALK_FLAG_UNION (XFS_EOF_FLAGS_UNION)
Do these internal flags need to have the same values as the user
API?
Otherwise OK.
Cheers,
Dave.
--
Dave Chinner
david@xxxxxxxxxxxxx
