Re: [PATCH 15/15] xfs: refactor per-AG inode tagging functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jun 03, 2021 at 11:16:16AM +1000, Dave Chinner wrote:
> On Wed, Jun 02, 2021 at 03:26:19PM -0700, Darrick J. Wong wrote:
> > From: Darrick J. Wong <djwong@xxxxxxxxxx>
> > 
> > In preparation for adding another incore inode tree tag, refactor the
> > code that sets and clears tags from the per-AG inode tree and the tree
> > of per-AG structures, and remove the open-coded versions used by the
> > blockgc code.
> > 
> > Note: For reclaim, we now rely on the radix tree tags instead of the
> > reclaimable inode count more heavily than we used to.  The conversion
> > should be fine, but the logic isn't 100% identical.
> > 
> > Signed-off-by: Darrick J. Wong <djwong@xxxxxxxxxx>
> > ---
> >  fs/xfs/xfs_icache.c |  158 +++++++++++++++++++++++++--------------------------
> >  fs/xfs/xfs_icache.h |    2 -
> >  fs/xfs/xfs_super.c  |    2 -
> >  fs/xfs/xfs_trace.h  |    6 +-
> >  4 files changed, 80 insertions(+), 88 deletions(-)
> 
> LGTM.
> 
> Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

Woo, thanks for reviewing!

--D

> -- 
> Dave Chinner
> david@xxxxxxxxxxxxx



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux