On Wed, Jun 02, 2021 at 03:25:57PM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong <djwong@xxxxxxxxxx> > > Soon we're going to be adding two new callers to the incore inode walk > code: reclaim of incore inodes, and (later) inactivation of inodes. > Both states operate on inodes that no longer have any VFS state, so we > need to move the xfs_irele calls into the processing functions. > > In other words, icwalk processing functions are responsible for cleaning > up whatever state changes are made by the corresponding icwalk igrab > function that picked the inode for processing. > > Signed-off-by: Darrick J. Wong <djwong@xxxxxxxxxx> > --- > fs/xfs/xfs_icache.c | 20 +++++++++++--------- > 1 file changed, 11 insertions(+), 9 deletions(-) All good. Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx> -- Dave Chinner david@xxxxxxxxxxxxx