Hi all, This set is a subset of a larger series for Dealyed Attributes. Which is a subset of a yet larger series for parent pointers. Delayed attributes allow attribute operations (set and remove) to be logged and committed in the same way that other delayed operations do. This allows more complex operations (like parent pointers) to be broken up into multiple smaller transactions. To do this, the existing attr operations must be modified to operate as a delayed operation. This means that they cannot roll, commit, or finish transactions. Instead, they return -EAGAIN to allow the calling function to handle the transaction. In this series, we focus on only the delayed attribute portion. We will introduce parent pointers in a later set. The set as a whole is a bit much to digest at once, so I usually send out the smaller sub series to reduce reviewer burn out. But the entire extended series is visible through the included github links. Updates since v18: Very minor nits, and also some additional clean up patches near the end. Patches 3 and 4 from the previous set have been merged, but otherwise the same. xfs: Add helper xfs_attr_set_fmt REMOVED xfs: Hoist xfs_attr_set_shortform REMOVED xfs: Refactor xfs_attr_set_shortform NEW This is a combination of the above two patches Did some white space clean up, but all other functional changes are the same RVB's retained xfs: Separate xfs_attr_node_addname and xfs_attr_node_addname_clear_incomplete Indentation nits xfs: Add delay ready attr remove routines Flow chart and comment typo nits xfs: Add delay ready attr set routines Flow chart typo fix Indentation fix in xfs_attr_rmtval_set_blk xfs: Remove xfs_attr_rmtval_set NEW xfs: Clean up xfs_attr_node_addname_clear_incomplete NEW xfs: Remove default ASSERT in xfs_attr_set_iter NEW xfs: Make attr name schemes consistent NEW EXTENDED SET xfs: Add helper function xfs_attr_leaf_addname NEW This series can be viewed on github here: https://github.com/allisonhenderson/xfs_work/tree/delay_ready_attrs_v19 As well as the extended delayed attribute and parent pointer series: https://github.com/allisonhenderson/xfs_work/tree/delay_ready_attrs_v19_extended And the test cases: https://github.com/allisonhenderson/xfs_work/tree/pptr_xfstestsv3 In order to run the test cases, you will need have the corresponding xfsprogs changes as well. Which can be found here: https://github.com/allisonhenderson/xfs_work/tree/delay_ready_attrs_xfsprogs_v19 https://github.com/allisonhenderson/xfs_work/tree/delay_ready_attrs_xfsprogs_v19_extended To run the xfs attributes tests run: check -g attr To run as delayed attributes run: export MOUNT_OPTIONS="-o delattr" check -g attr To run parent pointer tests: check -g parent I've also made the corresponding updates to the user space side as well, and ported anything they need to seat correctly. Questions, comment and feedback appreciated! Thanks all! Allison Allison Henderson (14): xfs: Reverse apply 72b97ea40d xfs: Add xfs_attr_node_remove_name xfs: Refactor xfs_attr_set_shortform xfs: Separate xfs_attr_node_addname and xfs_attr_node_addname_clear_incomplete xfs: Add helper xfs_attr_node_addname_find_attr xfs: Hoist xfs_attr_node_addname xfs: Hoist xfs_attr_leaf_addname xfs: Hoist node transaction handling xfs: Add delay ready attr remove routines xfs: Add delay ready attr set routines xfs: Remove xfs_attr_rmtval_set xfs: Clean up xfs_attr_node_addname_clear_incomplete xfs: Remove default ASSERT in xfs_attr_set_iter xfs: Make attr name schemes consistent fs/xfs/libxfs/xfs_attr.c | 899 ++++++++++++++++++++++++---------------- fs/xfs/libxfs/xfs_attr.h | 403 ++++++++++++++++++ fs/xfs/libxfs/xfs_attr_leaf.c | 4 +- fs/xfs/libxfs/xfs_attr_leaf.h | 2 +- fs/xfs/libxfs/xfs_attr_remote.c | 163 +++----- fs/xfs/libxfs/xfs_attr_remote.h | 8 +- fs/xfs/xfs_attr_inactive.c | 2 +- fs/xfs/xfs_trace.h | 2 - 8 files changed, 1018 insertions(+), 465 deletions(-) -- 2.7.4
