On Wed, May 19, 2021 at 09:08:50PM +0200, Christoph Hellwig wrote:
> Use a single goto label for freeing the buffer and returning an error.
>
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
Looks ok,
Reviewed-by: Darrick J. Wong <djwong@xxxxxxxxxx>
--D
> ---
> fs/xfs/xfs_buf.c | 15 +++++++--------
> 1 file changed, 7 insertions(+), 8 deletions(-)
>
> diff --git a/fs/xfs/xfs_buf.c b/fs/xfs/xfs_buf.c
> index 592800c8852f45..80be0333f077c0 100644
> --- a/fs/xfs/xfs_buf.c
> +++ b/fs/xfs/xfs_buf.c
> @@ -721,16 +721,12 @@ xfs_buf_get_map(
> return error;
>
> error = xfs_buf_allocate_memory(new_bp, flags);
> - if (error) {
> - xfs_buf_free(new_bp);
> - return error;
> - }
> + if (error)
> + goto out_free_buf;
>
> error = xfs_buf_find(target, map, nmaps, flags, new_bp, &bp);
> - if (error) {
> - xfs_buf_free(new_bp);
> - return error;
> - }
> + if (error)
> + goto out_free_buf;
>
> if (bp != new_bp)
> xfs_buf_free(new_bp);
> @@ -758,6 +754,9 @@ xfs_buf_get_map(
> trace_xfs_buf_get(bp, flags, _RET_IP_);
> *bpp = bp;
> return 0;
> +out_free_buf:
> + xfs_buf_free(new_bp);
> + return error;
> }
>
> int
> --
> 2.30.2
>
