On Wed, May 19, 2021 at 02:20:22PM +0100, Christoph Hellwig wrote: > On Wed, May 12, 2021 at 06:01:34PM -0700, Darrick J. Wong wrote: > > From: Darrick J. Wong <djwong@xxxxxxxxxx> > > > > sc->ip is the inode that's being scrubbed, which means that it's not set > > for scrub types that don't involve inodes. If one of those scrubbers > > (e.g. inode btrees) returns EDEADLOCK, we'll trip over the null pointer. > > Fix that by reporting either the file being examined or the file that > > was used to call scrub. > > Without an indication of which one we trace this is a little weird, > isn't it? Still better than a crash, though.. The scrub type is also encoded in the tracepoint, so we can tell that the inode number is meaningless. --D
