Re: [PATCH] libxfs: copy crtime correctly now that it's timespec64

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, May 05, 2021 at 10:01:42AM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@xxxxxxxxxx>
> 
> The incore i_mtime and di_crtime are both timespec64 now, which means
> that tv_sec is a 64-bit value.  Don't cast that to int32_t when we're
> creating an inode, because we'll end up truncating the creation time
> incorrectly, should an xfsprogs of this vintage make it to 2039. :P
> 
> Signed-off-by: Darrick J. Wong <djwong@xxxxxxxxxx>

I'm not sure the struct copy comment is all that useful, but otherwise
this looks good:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux