Re: [PATCH] mkfs: reject cowextsize after making final decision about reflink support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Apr 30, 2021 at 11:07:45PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@xxxxxxxxxx>
> 
> There's a snippet of code that rejects cowextsize option if reflink is
> disabled.  This really ought to be /after/ the last place where we can
> turn off reflink.  Fix it so that people don't see stuff like this:
> 
> $ mkfs.xfs -r rtdev=b.img a.img -f -d cowextsize=16
> illegal CoW extent size hint 16, must be less than 9600.
> 
> (reflink isn't supported when realtime is enabled)
> 
> Signed-off-by: Darrick J. Wong <djwong@xxxxxxxxxx>

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux