On Tue, Apr 20, 2021 at 10:36:34AM -0700, Darrick J. Wong wrote: > On Tue, Apr 20, 2021 at 09:22:54AM +0200, Christoph Hellwig wrote: > > Hi all, > > > > disabling quota accounting (vs just enforcement) on a running file system > > is a fundamentally race and hard to get right operation. It also has > > very little practical use. > > > > This causes xfs/007 xfs/106 xfs/220 xfs/304 xfs/305 to fail, as they > > specifically test this functionality. > > What kind of failures do you get now? Are they all a result of the > _ACCT flags never going away? Which I guess means that tests expecting > to get ENOSYS after you turn off _ACCT will now no longer error out? Sort of. Snipplets of the errors: xfs/007: core.nblocks = 1 *** turn off ug quotas +XFS_QUOTARM: Invalid argument *** umount *** Usage after quotarm *** -core.nblocks = 0 -core.nblocks = 0 +core.nblocks = 1 +core.nblocks = 1 xfs/106: -User quota are not enabled on SCRATCH_DEV +User quota state on SCRATCH_MNT (SCRATCH_DEV) + Accounting: ON + Enforcement: OFF + Inode: #131 (2 blocks, 2 extents) +Blocks grace time: [3 days 01:00:00] xfs/220: +XFS_QUOTARM: Invalid argument xfs/304: *** turn off project quotas +Quota already off. *** umount xfs/305: *** turn off project quotas +Quota already off. *** done
