On Tue, 2021-04-20 at 16:38 -0700, Darrick J. Wong wrote: > On Tue, Apr 20, 2021 at 06:06:52PM -0500, Gustavo A. R. Silva wrote: > > In preparation to enable -Wimplicit-fallthrough for Clang, fix > > the following warnings by replacing /* fall through */ comments, > > and its variants, with the new pseudo-keyword macro fallthrough: [] > > Notice that Clang doesn't recognize /* fall through */ comments as > > implicit fall-through markings, so in order to globally enable > > -Wimplicit-fallthrough for Clang, these comments need to be > > replaced with fallthrough; in the whole codebase. > > > > Link: https://github.com/KSPP/linux/issues/115 > > Signed-off-by: Gustavo A. R. Silva <gustavoars@xxxxxxxxxx> > > I've already NAKd this twice, so I guess I'll NAK it a third time. Sorry, I've must have missed it before. Why did you NAK this?
