On Tue, Apr 13, 2021 at 05:37:44PM -0700, Darrick J. Wong wrote: > On Mon, Apr 12, 2021 at 03:38:19PM +0200, Christoph Hellwig wrote: > > The in-memory XFS_IFEXTENTS is now only used to check if an inode with > > extents still needs the extents to be read into memory before doing > > operations that need the extent map. Add a new xfs_need_iread_extents > > helper that returns true for btree format forks that do not have any > > entries in the in-memory extent btree, and use that instead of checking > > the XFS_IFEXTENTS flag. > > > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> > > The series seems reasonable to me, though I wonder if Dave will have > strong(er) opinions? No, I've already said I'm fine with making these changes to remove the ambiguity. I've only briefly scan of the patches, but I didn't see anything that I disagree with that would make me stop, context switch and ask to be changed... Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx
