On Tue, Apr 06, 2021 at 06:51:06AM -0700, Darrick J. Wong wrote: > > index 5574d345d066ed..b8cab14ca8ce8d 100644 > > --- a/fs/xfs/libxfs/xfs_bmap.c > > +++ b/fs/xfs/libxfs/xfs_bmap.c > > @@ -1223,6 +1223,9 @@ xfs_iread_extents( > > > > ASSERT(xfs_isilocked(ip, XFS_ILOCK_EXCL)); > > Since we now call xfs_iread_extents unconditionally, this assert will > trip every time someone wants to bmapi_read the extent data after the > extent data has been loaded in, because xfs_ilock_data_map_shared tells > callers they only need to take ILOCK_SHARED... right? Yes. I've already moved this down in my local tree, as xfstests generic/001 hits this once XFS_DEBUG is enabled. I also had to fix the inode variable name in a few places to even make that config compile. As said this was _very_ lightly tested - I only did a quick run on a non-debug config, but that passed with flying colors :)
