On Fri, Apr 02, 2021 at 08:02:37AM +0100, Christoph Hellwig wrote: > On Wed, Mar 31, 2021 at 08:40:07AM +1100, Dave Chinner wrote: > > What > > should have been done in 6bdcf26ade88 is the XFS_IFEXTENTS format > > fork should have become XFS_IFEXTENTS|XFS_IFEXTIREC to indicate > > "extent format, extent tree populated", rather than eliding > > XFS_IFEXTIREC and redefining XFS_IFEXTENTS to mean "extent tree > > populated". i.e. the separate flag to indicate the difference > > between fork format and in-memory state should have been > > retained.... > > I strongly disagree. If we want to clean this up the right thing is > to remove XFS_IFINLINE and XFS_IFBROOT entirely, and just look at the > if_format field for the extent format. Sounds great, but regardless of the historical argument, this bug still needs to be fix, and removing XFS_IFINLINE/XFS_IFBROOT is far to much for what is effectively a one liner... Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx
