On Tue, Mar 30, 2021 at 04:30:59PM +1100, Dave Chinner wrote: > +unsigned int > +xfs_bmap_compute_attr_offset( > + struct xfs_mount *mp) > +{ > + if (mp->m_sb.sb_inodesize == 256) > + return XFS_LITINO(mp) - XFS_BMDR_SPACE_CALC(MINABTPTRS); > + return XFS_BMDR_SPACE_CALC(6 * MINABTPTRS); > +} There isn't really anything bmap about this function. Maybe just merge it into xfs_mount_setup_inode_geom? Otherwise looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>