On Thu, Apr 01, 2021 at 10:15:25PM +0530, Chandan Babu R wrote:
> @@ -927,13 +927,16 @@ xfs_bmap_add_attrfork_btree(
> xfs_inode_t *ip, /* incore inode pointer */
> int *flags) /* inode logging flags */
> {
> + struct xfs_btree_block *block;
> xfs_btree_cur_t *cur; /* btree cursor */
> int error; /* error return value */
> xfs_mount_t *mp; /* file system mount struct */
> int stat; /* newroot status */
>
> mp = ip->i_mount;
> - if (ip->i_df.if_broot_bytes <= XFS_IFORK_DSIZE(ip))
> + block = ip->i_df.if_broot;
Just initializing block o nthe line it is declared would read a little
easier. Other than that this looks good:
Reviewed-by: Christoph Hellwig <hch@xxxxxx>
