Re: [PATCH v3 1/8] repair: turn bad inode list into array

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Darrick,

On Tue, Mar 30, 2021 at 11:46:08AM -0700, Darrick J. Wong wrote:
> On Tue, Mar 30, 2021 at 10:25:24PM +0800, Gao Xiang wrote:
> > From: Gao Xiang <hsiangkao@xxxxxxxxxx>
> > 
> > Just use array and reallocate one-by-one here (not sure if bulk
> > allocation is more effective or not.)
> 
> I'm not sure either.  The list of bad directories is likely to be
> sparse, so perhaps the libfrog bitmap isn't going to beat a realloc
> array for space efficiency... and reusing the slab array might be
> overkill for an array-backed bitmap?
> 
> Eh, you know what?  I don't think the bad directory bitmap is hot enough
> to justify broadening this into an algorithmic review of data
> structures.  Incremental space efficiency is good enough for me.

I'm not sure if it's a good choice tbh, let me try to use some
balanced binary tree instead as Dave suggested.

Thanks,
Gao Xiang




[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux