On 29 Mar 2021 at 23:36, Darrick J. Wong wrote: > On Thu, Mar 25, 2021 at 07:38:57PM +0530, Chandan Babu R wrote: >> xfs/535 attempts to create $srcfile and $dstfile after reduce_max_iextents >> error tag is injected. Creation of these files fails when using a multi-block >> directory test configuration because, >> 1. A directory can have a pseudo maximum extent count of 10. >> 2. In the worst case a directory entry creation operation can consume >> (XFS_DA_NODE_MAXDEPTH + 1 + 1) * (Nr fs blocks in a single directory block) >> extents. >> With 1k fs block size and 4k directory block size, this evaluates to, >> (5 + 1 + 1) * 4 >> = 7 * 4 >> = 28 >> > 10 (Pseudo maximum inode extent count). >> >> This commit fixes the issue by creating $srcfile and $dstfile before injecting >> reduce_max_iextents error tag. >> >> Reported-by: Darrick J. Wong <djwong@xxxxxxxxxx> >> Suggested-by: Darrick J. Wong <djwong@xxxxxxxxxx> >> Signed-off-by: Chandan Babu R <chandanrlinux@xxxxxxxxx> > > Now on to the xfs/538 regressions! ;) Yup, I am working on them. > Reviewed-by: Darrick J. Wong <djwong@xxxxxxxxxx> Thanks for the review! I will fold patches 2 to 6 into a single patch and repost. -- chandan
