> +/* Forward declarations to reduce indirect calls */ > +static int xfs_blockgc_scan_inode(struct xfs_inode *ip, void *args); While we try to avoid forward declarations I don't think we really need a comment justifying it. Otherwise this looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>