On Thu, Mar 25, 2021 at 05:21:05PM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong <djwong@xxxxxxxxxx> > > In xfs_inode_free_eofblocks, move the xfs_can_free_eofblocks call > further down in the function to the point where we have taken the > IOLOCK. This is preparation for the next patch, where we will need that > lock (or equivalent) so that we can check if there are any post-eof > blocks to clean out. I kinda prefer the old style that did the exception path inside the branch. But that is just sugacoating, the actual change looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>