On Wed, Mar 24, 2021 at 07:28:49PM +0100, Christoph Hellwig wrote: > On Wed, Mar 24, 2021 at 11:27:25AM -0700, Darrick J. Wong wrote: > > On Wed, Mar 24, 2021 at 03:21:17PM +0100, Christoph Hellwig wrote: > > > The xfs_icdinode structure just contains a random mix of inode field, > > > which are all read from the on-disk inode and mostly not looked at > > > before reading the inode or initializing a new inode cluster. The > > > only exceptions are the forkoff and blocks field, which are used > > > in sanity checks for freshly allocated inodes. > > > > > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> > > > > Hmm, does this fix the crash I complained about last time? > > > > https://lore.kernel.org/linux-xfs/20200702183426.GD7606@magnolia/ > > > > I /think/ it does, but can't tell for sure from the comments. :/ > > Your crash was due to the uninitialized diflags2, which is fixed very > early on in the series. Ah, ok. I thought that might be the proper fix for that. At the very least, the repro instructions don't lead to a crash this time, so I'll toss this series at fstests cloud and see if anything falls out. Reviewed-by: Darrick J. Wong <djwong@xxxxxxxxxx> --D
