Re: [PATCH v3 01/10] fsdax: Factor helpers to simplify dax fault code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 3/19/21 7:22 AM, Shiyang Ruan wrote:
The dax page fault code is too long and a bit difficult to read. And it
is hard to understand when we trying to add new features. Some of the
PTE/PMD codes have similar logic. So, factor them as helper functions to
simplify the code.

Signed-off-by: Shiyang Ruan <ruansy.fnst@xxxxxxxxxxx>
Reviewed-by: Christoph Hellwig <hch@xxxxxx>
---
  fs/dax.c | 152 ++++++++++++++++++++++++++++++-------------------------
  1 file changed, 84 insertions(+), 68 deletions(-)


Refactoring & the changes looks good to me.
Feel free to add.

Reviewed-by: Ritesh Harjani <riteshh@xxxxxxxxxxxxx>



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux