On Fri, Mar 19, 2021 at 04:32:49PM +0100, Pavel Reichl wrote: > Hello, > > I belive that this patch set was missed in recent for-next branch update. > > Patches are the same as before I just added the reviewed-by tags. Yeah, I'll have time to start on xfs-5.13-merge next week. Thanks for respinning this. :) --D > Thanks! > > ... > At least some version of mount will look in /proc/mounts and send in all of the > options that it finds as part of a remount command. We also /do/ still emit > "attr2" in /proc/mounts (as we probably should), so remount passes that back > in, and we emit a warning, which is not great. > > In other words mount passes in "attr2" and the kernel emits a deprecation > warning for attr2, even though the user/admin never explicitly asked for the > option. > > So, lets skip the warning if (we are remounting && deprecated option > state is not changing). > > I also attached test for xfstests that I used for testing (the test > will be proposed on xfstests-list after/if this patch is merged). > > V2 vs. V1 > > * Added new patch that renames mp to parsing_mp in xfs_fs_parse_param() > * Added new function xfs_fs_warn_deprecated() to encapsulate the logic for displaying the deprecation warning. > * Fixed some white space issues. > > Pavel Reichl (2): > xfs: rename variable mp to parsing_mp > xfs: Skip repetitive warnings about mount options > > fs/xfs/xfs_super.c | 118 +++++++++++++++++++++++++-------------------- > 1 file changed, 67 insertions(+), 51 deletions(-) > > -- > 2.30.2 >
