On Thu, Mar 18, 2021 at 11:01:10PM -0700, Darrick J. Wong wrote: > I don't think so, because xfs_free_eofblocks will call > xfs_inode_clear_eofblocks_tag if it succeeds in freeing anything. > > Though perhaps you're correct that we need to clear the tag if > !xfs_can_free_eofblocks, since we could have been called if > XFS_ICI_BLOCKGC_TAG was set in the radix tree because we once had a > posteof block but now we really only have cow blocks. Yes, that's what I meant.