> @@ -818,9 +818,7 @@ xlog_wait_on_iclog( > static int > xlog_write_unmount_record( > struct xlog *log, > - struct xlog_ticket *ticket, > - xfs_lsn_t *lsn, > - uint flags) > + struct xlog_ticket *ticket) > { > struct xfs_unmount_log_format ulf = { > .magic = XLOG_UNMOUNT_TYPE, > @@ -837,7 +835,7 @@ xlog_write_unmount_record( > > /* account for space used by record data */ > ticket->t_curr_res -= sizeof(ulf); > - return xlog_write(log, &vec, ticket, lsn, NULL, flags, false); > + return xlog_write(log, &vec, ticket, NULL, NULL, XLOG_UNMOUNT_TRANS); The removal of the lsn argument from xlog_write_unmount_record and making optional of the start_lsn argument to xlog_write is not documented anywhere. I still it would be best to split such tiny argument passing cleanups from a more complicated and not quite trivial one, but at very least it needs to be clearly documented.