Re: [PATCH 2/3 v2] xfs: AIL needs asynchronous CIL forcing\

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Mar 08, 2021 at 08:35:59PM -0800, Darrick J. Wong wrote:
> > So you won't review it until I have 100 outstanding patches in this
> > series and it's completely and utterly unreviewable?
> 
> Already unreviewable at 45, and I've only gotten through 2/3 of it.


Yes.  For patches that don't just repetitively apply similar changes
to a few places, about 20 patches is the max that is digestable.

> Here's something I haven't previously shared with all of you: Last cycle
> when we were going around and around on the ENOSPC/EDQUOT retry loop
> patches (which exploded from 13 to 41 patches) it was /very/ stressful
> to have to rework this and that part every day and a half for almost
> three weeks.

As someone part of the loop I was a little surprised how quickly you
did respin the patches.  In general if I have feedback that requires
a major rework of a non-trivial series, I do not want to touch it
instantly.  Let the discussion continue a bit, becaue it can easily
turn into another direction and create more work.  I think waiting a few
days before doing anything that involves a lot of work generally helpsto
make everyones life a little easier.

> (TLDR: git branch plz)

Yes, for any non-trivial series that really, really helps.



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux