On Thu, Feb 25, 2021 at 03:21:53PM -0800, Darrick J. Wong wrote:
> On Tue, Feb 23, 2021 at 10:05:56AM +1100, Dave Chinner wrote:
> > From: Dave Chinner <dchinner@xxxxxxxxxx>
> > STATIC int
> > xfs_generic_create(
> > struct inode *dir,
> > @@ -161,7 +192,9 @@ xfs_generic_create(
> > goto out_free_acl;
> >
> > if (!tmpfile) {
> > - error = xfs_create(XFS_I(dir), &name, mode, rdev, &ip);
> > + error = xfs_create(XFS_I(dir), &name, mode, rdev,
> > + xfs_create_need_xattr(dir, default_acl, acl),
> > + &ip);
> > } else {
> > error = xfs_create_tmpfile(XFS_I(dir), mode, &ip);
>
> Same question as last time: Do selinux or smack want to set xattr-based
> security labels on tempfiles too?
I think they do, but nobody has ever indicated that O_TMPFILE
creation to to be performance critical. Until someone comes to me
and says "concurrent O_TMPFILE creation at scale is really important
to our workload", I'm largely ignoring scalability issues for
tmpfile creation. Especially because AGI locks and the unlinked list
manipulations are the bottleneck here, not xattr creation....
Cheers,
Dave.
--
Dave Chinner
david@xxxxxxxxxxxxx
