On Wed, Feb 24, 2021 at 01:42:35PM -0800, Darrick J. Wong wrote: > FWIW I rather wish you'd defined a new type for cil sequence numbers, > since uint64_t is rather generic. Even if checkpatch whines about new > typedefs. > > I was kind of hoping that we'd be able to mark xfs_lsn_t and xfs_csn_t > with __bitwise and so static checkers could catch us if we accidentally > feed a CIL sequence number into a function that wants an LSN. __bitwise is a rather bad fit for xfs_lsn_t. It is used as scalar and not flags for which __bitwise is used, and it is written to disk in many places. Any in case you're asking: I tried to quickly convert it and noticed that the hard way.
