At least some version of mount will look in /proc/mounts and send in all of the options that it finds as part of a remount command. We also /do/ still emit "attr2" in /proc/mounts (as we probably should), so remount passes that back in, and we emit a warning, which is not great. In other words mount passes in "attr2" and the kernel emits a deprecation warning for attr2, even though the user/admin never explicitly asked for the option. So, lets skip the warning if (we are remounting && deprecated option state is not changing). I also attached test for xfstests that I used for testing (the test will be proposed on xfstests-list after/if this patch is merged). V2 vs. V1 Kernel: * Added new patch that renames mp to parsing_mp in xfs_fs_parse_param() * Added new function xfs_fs_warn_deprecated() to encapsulate the logic for displaying the deprecation warning. * Fixed some white space issues. Test: * Skip test on old kernels that don't print any deprecation warning. Pavel Reichl (2): xfs: rename variable mp to parsing_mp xfs: Skip repetitive warnings about mount options fs/xfs/xfs_super.c | 118 +++++++++++++++++++++++++-------------------- 1 file changed, 67 insertions(+), 51 deletions(-) -- 2.29.2
