On 2/23/21 12:25 PM, Darrick J. Wong wrote: >> Ok, yup, I see. so I guess we kind of have: >> >> *parsing_mp = fc->s_fs_info; >> >> and >> >> *current_mp = XFS_M(fc->root->d_sb); >> >> (variable names not actually in the code, just used for example) > > Maybe they should be. ;) Yup I almost suggested at least a comment. And since we do care about the actual/live *mp now, maybe adding self-describing variable names would be a help. -Eric > --D > >> Sorry for the noise, my mistake! >> >> -Eric >
