On 2/22/21 8:00 PM, Darrick J. Wong wrote:
From: Darrick J. Wong <djwong@xxxxxxxxxx>
Clean up the string quoting in this script so that we don't trip over
users feeding us arguments like "/dev/sd ha ha ha lol".
Signed-off-by: Darrick J. Wong <djwong@xxxxxxxxxx>
Reviewed-by: Brian Foster <bfoster@xxxxxxxxxx>
Reviewed-by: Christoph Hellwig <hch@xxxxxx>
Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@xxxxxxx>
Looks ok
Reviewed-by: Allison Henderson <allison.henderson@xxxxxxxxxx>
---
db/xfs_admin.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/db/xfs_admin.sh b/db/xfs_admin.sh
index bd325da2..71a9aa98 100755
--- a/db/xfs_admin.sh
+++ b/db/xfs_admin.sh
@@ -43,7 +43,7 @@ case $# in
if [ -n "$DB_OPTS" ]
then
- eval xfs_db -x -p xfs_admin $DB_OPTS $1
+ eval xfs_db -x -p xfs_admin $DB_OPTS "$1"
status=$?
fi
if [ -n "$REPAIR_OPTS" ]
@@ -53,7 +53,7 @@ case $# in
# running xfs_admin.
# Ideally, we need to improve the output behaviour
# of repair for this purpose (say a "quiet" mode).
- eval xfs_repair $REPAIR_OPTS $1 2> /dev/null
+ eval xfs_repair $REPAIR_OPTS "$1" 2> /dev/null
status=`expr $? + $status`
if [ $status -ne 0 ]
then
