On Fri, Feb 12, 2021 at 01:48:02PM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@xxxxxxxxxx>
>
> In commit 9669f51de5c0 I tried to get rid of the undocumented cow gc
> lifetime knob. The knob's function was never documented and it now
> doesn't really have a function since eof and cow gc have been
> consolidated.
>
> Regrettably, xfs/231 relies on it and regresses on for-next. I did not
> succeed at getting far enough through fstests patch review for the fixup
> to land in time.
>
> Restore the sysctl knob, document what it did (does?), put it on the
> deprecation schedule, and rip out a redundant function.
>
> Fixes: 9669f51de5c0 ("xfs: consolidate the eofblocks and cowblocks workers")
> Signed-off-by: Darrick J. Wong <djwong@xxxxxxxxxx>
> ---
> v2: use printk_ratelimited
> ---
Looks good.
Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>
--
Dave Chinner
david@xxxxxxxxxxxxx
