On Tue, Feb 09, 2021 at 08:41:34AM -0600, Eric Sandeen wrote: > > > On 2/9/21 3:15 AM, Christoph Hellwig wrote: > > On Mon, Feb 08, 2021 at 08:10:49PM -0800, Darrick J. Wong wrote: > >> From: Darrick J. Wong <djwong@xxxxxxxxxx> > >> > >> Quietly set up the ability to tell xfs_repair to set NEEDSREPAIR at > >> program start and (presumably) clear it by the end of the run. This > >> code isn't terribly useful to users; it's mainly here so that fstests > >> can exercise the functionality. > > > > What does the quietly above mean? > > I think it means "don't document it in the man page, this is a secret > for XFS developers and testers" Yep. I'll add the following to the commit message: "We don't document this flag in the manual pages at all because repair clears needsrepair at exit, which means the knobs only exist for fstests to exercise the functionality." --D > > > Otherwise this looks good: > > > > Reviewed-by: Christoph Hellwig <hch@xxxxxx> > >
