On Wed, Feb 03, 2021 at 09:16:33AM -0800, Darrick J. Wong wrote: > On Wed, Feb 03, 2021 at 03:41:25PM +0100, Christian Brauner wrote: > > On Wed, Feb 03, 2021 at 03:30:17PM +0100, Christoph Hellwig wrote: > > > On Wed, Feb 03, 2021 at 02:47:34PM +0100, Christian Brauner wrote: > > > > In the final version of you conversion (after the file_user_ns() > > > > introduction) we simply pass down the fp so the patch needs to be? > > > > > > > > If you're happy with it I can apply it on top. I don't want to rebase > > > > this late. I can also send it separate as a reply in case this too much > > > > in the body of this mail. > > > > > > > > Patch passes cross-compilation for arm64 and native x864-64 and xfstests > > > > pass too: > > > > > > Let's wait for an ACK from Darrick, but I'd be fine with this. > > > > Sounds good! > > Christian > > Seems fine to me, but can one of you please send this as a proper patch? > :) Yeah, for sure! > > FWIW I really would prefer we make the tooling smart enough to shut up > about "unused" variables and "dead" code simply because we #define'd > their usage out of existence. But since refactoring gcc/clang is > probably even more of an ocean-boiling approach I'll just invite you all > to join the XFS quota refactoring party. :P In 2021 that might indeed qualify as a party... :) Christian
