On Mon, Feb 01, 2021 at 06:04:31PM -0800, Darrick J. Wong wrote: > From: Darrick J. Wong <djwong@xxxxxxxxxx> > > For file ownership (uid, gid, prid) changes, create a new helper > xfs_trans_alloc_ichange that allocates a transaction and reserves the > appropriate amount of quota against that transction in preparation for a > change of user, group, or project id. Replace all the open-coded idioms > with a single call to this helper so that we can contain the retry loops > in the next patchset. > > This changes the locking behavior for ichange transactions slightly. > Since tr_ichange does not have a permanent reservation and cannot roll, > we pass XFS_ILOCK_EXCL to ijoin so that the inode will be unlocked > automatically at commit time. > > Signed-off-by: Darrick J. Wong <djwong@xxxxxxxxxx> Looks good, Reviewed-by: Christoph Hellwig <hch@xxxxxx>