On Mon, Feb 01, 2021 at 12:17:30PM +0000, Christoph Hellwig wrote: > So looking at what is left of this function after your first patch > I'd be tempted to just open code it. Right now it has two callsites > which either to udqp/gdqp or pdqp, althoug with your late changes > we're even down to one. And the current callers kinda duplicate > the checks in it, I need to look at the new code in a little more > detail, though. Yeah. I've dropped this patch in favor of open-coding a call to xfs_trans_reserve_quota_bydquots in xfs_trans_alloc_ichange.