On Thu, Jan 28, 2021 at 09:49:54AM +0000, Christoph Hellwig wrote: > On Wed, Jan 27, 2021 at 10:01:38PM -0800, Darrick J. Wong wrote: > > From: Darrick J. Wong <djwong@xxxxxxxxxx> > > > > Modify xfs_trans_reserve_quota_nblks so that we can reserve data and > > realtime blocks from the dquot at the same time. This change has the > > theoretical side effect that for allocations to realtime files we will > > reserve from the dquot both the number of rtblocks being allocated and > > the number of bmbt blocks that might be needed to add the mapping. > > However, since the mount code disables quota if it finds a realtime > > device, this should not result in any behavior changes. > > > > This also replaces the flags argument with a force? boolean since we > > don't need to distinguish between data and rt quota reservations any > > more, and the only other flag being passed in was FORCE_RES. > > It a removes the entirely unused nino flag, which caused quite some > confusion to me when reading this patch, so please document that. D'oh, sorry. I think I accidentally removed a sentence from the second paragraph somehow. :( It /should/ read: "Now that we've moved the inode creation code away from using the _nblks function, we can repurpose the (now unused) ninos argument for realtime blocks, so make that change. This also replaces the flags argument... > Otherwise this looks good: > > Reviewed-by: Christoph Hellwig <hch@xxxxxx> Thanks! --D
