On Wed, Jan 27, 2021 at 10:04:41PM -0800, Darrick J. Wong wrote: > From: Darrick J. Wong <djwong@xxxxxxxxxx> > > Since xfs_inode_free_eofblocks and xfs_inode_free_cowblocks are now > internal static functions, we can save ourselves a cycling of the iolock > by passing the lock state out to xfs_blockgc_scan_inode and letting it > do all the unlocking. Looks good, although normally we use lock_flags and not unlockflags for this kind of variable, and maybe we should stick to that here. Reviewed-by: Christoph Hellwig <hch@xxxxxx>
