On Sun, Jan 24, 2021 at 09:57:17AM +0000, Christoph Hellwig wrote: > On Sat, Jan 23, 2021 at 10:53:08AM -0800, Darrick J. Wong wrote: > > ASSERT(agno < mp->m_sb.sb_agcount); > > ASSERT(!(flags & ~XFS_IWALK_FLAGS_ALL)); > > > > - nr_threads = xfs_pwork_guess_datadev_parallelism(mp); > > - error = xfs_pwork_init(mp, &pctl, xfs_iwalk_ag_work, "xfs_iwalk", > > - nr_threads); > > + error = xfs_pwork_init(mp, &pctl, xfs_iwalk_ag_work, "xfs_iwalk", 0); > > > Why not drop the last argument to xfs_pwork_init as well? Also I don't > think this makes sense as a standalone step without the changes in the > next patch. Ok, I'll combine these two. --D