On Sun, Jan 17, 2021 at 08:27:04PM -0800, Darrick J. Wong wrote: > On Mon, Jan 18, 2021 at 10:18:48AM +1100, Dave Chinner wrote: > > On Fri, Jan 15, 2021 at 05:46:07PM -0800, Darrick J. Wong wrote: > > > On Thu, Oct 29, 2020 at 02:27:13PM -0700, Darrick J. Wong wrote: > > > > On Wed, Oct 28, 2020 at 07:54:50AM +1100, Dave Chinner wrote: > > > > > +echo End of line comment > > > > > +test_mkfs_config << ENDL > > > > > +[metadata] > > > > > +crc = 0 ; This is an eol comment. > > > > > > > > Hey, wait a minute, the manpage didn't say I could use semicolon > > > > comments! :) > > > > > > > > The libinih page https://github.com/benhoyt/inih says you can though. > > > > > > > > Would you mind making a note of that in patch 5 above, please? > > > > > > Ping? The mkfs code has been merged upstream; we ought to land the > > > functionality tests. > > > > Nothing in this patch needs to change, AFAIA, because you were > > referring to the xfsprogs mkfs patchset in your comment. So this > > is really only waiting on review, right? Do I need to repost it? > > Probably, as it's entirely possible that it's gotten lost in Eryu's mail > stream. You were right, it's lost in my 'to-review' queue.. Thanks for the reminder! I did some minor modifications to the patches, such as update supported fs from 'generic' to 'xfs', and change truncate command to $XFS_IO_PROG -c "truncate". Thanks, Eryu > > --D > > > -Dave. > > -- > > Dave Chinner > > david@xxxxxxxxxxxxx
