On Tue, Jan 19, 2021 at 07:44:03AM +0100, Christoph Hellwig wrote: > > - error = xfs_trans_reserve_quota_nblks(NULL, ip, (long)alen, 0, > > - XFS_QMOPT_RES_REGBLKS); > > + error = xfs_quota_reserve_blkres(ip, alen, XFS_QMOPT_RES_REGBLKS); > > This is the only callsite outside of xfs_quota_unreserve_blkres, > so I'm not sure how useful the wrapper is. Also even on the unreserved > side we always pass XFS_QMOPT_RES_REGBLKS except for one case that > conditionally passes XFS_QMOPT_RES_RTBLKS. So if we think these helpers > are useful enough I'd at least just pass a bool is_rt argument and hide > the flags entirely. Seeing as XFS doesn't even let you mount with quota and rt, I elect to get rid of the third parameter entirely. Whoever decides to make them work together will have a lot of work to do beyond fixing that one unreserve call. --D
