On Wed, Jan 13, 2021 at 03:34:18PM +0100, Christoph Hellwig wrote: > On Mon, Jan 11, 2021 at 03:22:40PM -0800, Darrick J. Wong wrote: > > From: Darrick J. Wong <djwong@xxxxxxxxxx> > > > > Hide the incore inode walk interface because callers outside of the > > icache code don't need to know about iter_flags and radix tags and other > > implementation details of the incore inode cache. > > This looks correct, but I'm still rather lukewarm on all the extra code > just to hide a single flags argument. Yeah, I looked at the extra patches that are now in this series to deal with the cleanups mentioned in other review comments and decided to drop this. --D