On Mon, Jan 11, 2021 at 03:22:46PM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@xxxxxxxxxx>
>
> The functions to run an eof/cowblocks scan to try to reduce quota usage
> are kind of a mess -- the logic repeatedly initializes an eofb structure
> and there are logic bugs in the code that result in the cowblocks scan
> never actually happening.
>
> Replace all three functions with a single function that fills out an
> eofb if we're low on quota and runs both eof and cowblocks scans.
>
> Fixes: 83104d449e8c4 ("xfs: garbage collect old cowextsz reservations")
This just cleans things up and doesn't actually fix any bug, does it?
> diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c
> index 5b0f93f73837..5d5cf25668b5 100644
> --- a/fs/xfs/xfs_file.c
> +++ b/fs/xfs/xfs_file.c
> @@ -652,7 +652,7 @@ xfs_file_buffered_aio_write(
> struct inode *inode = mapping->host;
> struct xfs_inode *ip = XFS_I(inode);
> ssize_t ret;
> - int enospc = 0;
> + bool cleared_space = false;
The variable renaming here looks useful, but unrelated to the rest.
Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch@xxxxxx>
