On Tue, Jan 12, 2021 at 05:26:10PM +0100, Christoph Hellwig wrote: > The iomap code has been designed from the start not to do magic fallback, > so remove the assert in preparation for further code cleanups. > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> > --- > fs/xfs/xfs_file.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c > index ae7313ccaa11ed..97836ec53397d4 100644 > --- a/fs/xfs/xfs_file.c > +++ b/fs/xfs/xfs_file.c > @@ -610,12 +610,6 @@ xfs_file_dio_write( > out: > if (iolock) > xfs_iunlock(ip, iolock); > - > - /* > - * No fallback to buffered IO after short writes for XFS, direct I/O > - * will either complete fully or return an error. > - */ > - ASSERT(ret < 0 || ret == count); > return ret; > } Looks good. Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx> -- Dave Chinner david@xxxxxxxxxxxxx
