On Tue, Jan 12, 2021 at 10:33:47AM -0500, Brian Foster wrote: > Looks fine, though it might be nice to find some commonality with > xfs_log_force_inode(): The common logic is called xfs_log_force_lsn :) The fact that fsync checks and modifies ili_fsync_fields makes it rather impractival to share more code unfortunately.