On Wed, Jan 06, 2021 at 12:41:27PM -0500, Brian Foster wrote: > Filesystem freeze cleans the log and immediately redirties it so log > recovery runs if a crash occurs after the filesystem is frozen. Now > that log quiesce covers the log, there is no need to clean the log and > redirty it to trigger log recovery because covering has the same > effect. Update xfs_fs_freeze() to quiesce (and thus cover) the log. > > Signed-off-by: Brian Foster <bfoster@xxxxxxxxxx> Woot! Reviewed-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx> --D > --- > fs/xfs/xfs_super.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c > index aedf622d221b..aed74a3fc787 100644 > --- a/fs/xfs/xfs_super.c > +++ b/fs/xfs/xfs_super.c > @@ -889,8 +889,7 @@ xfs_fs_freeze( > flags = memalloc_nofs_save(); > xfs_stop_block_reaping(mp); > xfs_save_resvblks(mp); > - xfs_log_clean(mp); > - ret = xfs_sync_sb(mp, true); > + ret = xfs_log_quiesce(mp); > memalloc_nofs_restore(flags); > return ret; > } > -- > 2.26.2 >
