On Thu, Dec 17, 2020 at 02:06:09PM +1100, Dave Chinner wrote: > On Thu, Dec 17, 2020 at 09:11:54AM +0800, Yafang Shao wrote: > > From: "Matthew Wilcox (Oracle)" <willy@xxxxxxxxxxxxx> > > > > Since XFS needs to pretend to be kswapd in some of its worker threads, > > create methods to save & restore kswapd state. Don't bother restoring > > kswapd state in kswapd -- the only time we reach this code is when we're > > exiting and the task_struct is about to be destroyed anyway. ... > > @@ -3932,8 +3920,6 @@ static int kswapd(void *p) > > goto kswapd_try_sleep; > > } > > > > - tsk->flags &= ~(PF_MEMALLOC | PF_SWAPWRITE | PF_KSWAPD); > > - > > Missing a restore_kswapd()? Deliberately.